Skip to content

Feat/#4 북마크 목록 조회#7

Merged
pu2rile merged 7 commits into
devfrom
feat/#4_get_bookmarks
Jun 4, 2025
Merged

Feat/#4 북마크 목록 조회#7
pu2rile merged 7 commits into
devfrom
feat/#4_get_bookmarks

Conversation

@pu2rile
Copy link
Copy Markdown
Collaborator

@pu2rile pu2rile commented May 23, 2025

#️⃣ 연관된 이슈

📝 작업 내용

북마크 관련 기능 중 북마크 목록 조회 기능을 구현했습니다.
가게 및 유저 도메인이 아직 추가되지 않아서 임시 데이터 기반으로 구조를 설계했습니다.

1️⃣ 북마크 목록 조회 기능 구현

  • GET /api/bookmarks/{userId} 경로를 통해 특정 유저의 북마크된 storeId 목록을 조회합니다.
  • 응답은 BookmarkInfo(storeId) 리스트를 BookmarkResponse(bookmarks: List<BookmarkInfo>) 형태로 감쌌습니다.
  • 일단 지금은 storeId만 응답하는데, 추후 가게 도메인이 연결되면 가게 이름, 썸네일 사진 등을 포함할 예정입니다.
    public record BookmarkInfo(
        Long storeId
    ) {}

2️⃣ 연관 도메인 부재 이슈

연관관계

  • 가게 및 유저 도메인이 아직 존재하지 않아서 일단 간단하게 userId, storeId로 처리했습니다.
  • 이후 도메인 추가 시 연관관계 매핑으로 리팩토링할 예정입니다.

테스트

  • 관련 도메인이 없다 보니 RestDocs 테스트 시 목데이터를 세팅하는 데에 어려움이 있기 때문에 리팩토링 후 RestDocs 테스트를 진행해서 문서화할 예정입니다.
  • 대신 @ Mock 기반의 순수 유닛 테스트를 작성하여 서비스 로직에 대한 검증은 완료했습니다.

💬 리뷰 요구사항 (선택)

이상한 부분 있으면 코멘트 달아주세요...
어 지금 보니 엔티티 추가 커밋에 build.gradle이 같이 들어갔네요 죄송합니다... jpa랑 lombok 넣었어요

@pu2rile pu2rile self-assigned this May 23, 2025
@pu2rile pu2rile linked an issue May 23, 2025 that may be closed by this pull request
4 tasks
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pu2rile pu2rile added the 🌟 feat 기능 개발 관련 이슈 label May 23, 2025
@Hooneybadger Hooneybadger changed the base branch from main to dev May 23, 2025 02:31
@pu2rile pu2rile merged commit 3dcee40 into dev Jun 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 feat 기능 개발 관련 이슈

Projects

None yet

Development

Successfully merging this pull request may close these issues.

북마크 목록 조회

1 participant