Skip to content

Feat/#13 회원가입 구현 + 인증 흐름 정리#15

Merged
Hooneybadger merged 11 commits into
devfrom
feat/#13_auth_signup
Jun 4, 2025
Merged

Feat/#13 회원가입 구현 + 인증 흐름 정리#15
Hooneybadger merged 11 commits into
devfrom
feat/#13_auth_signup

Conversation

@Dolchae
Copy link
Copy Markdown
Collaborator

@Dolchae Dolchae commented May 31, 2025

#️⃣ 연관된 이슈

📝 작업 내용

회원가입 기능을 구현하고, 전체적인 인증 흐름을 정리했습니다!

1️⃣ 회원가입 기능 구현

  • /api/signup API + 응답 DTO 설계
  • 회원정보 저장 후 JWT 발급

2️⃣ 인증 기반 구조 구축

  • Spring Security 설정
  • JWT 발급 구조: 원래 email 기반 → provider:providerId 방식으로 변경
  • JwtAuthenticationFilter 적용 및 등록

3️⃣ 인증 사용자 처리 & 유틸

  • @CurrentMember 어노테이션 구현
  • 로그인된 사용자 정보 조회 (/api/member/me)
  • FCM 토큰 저장 기능 (/api/member/fcm)

4️⃣ 테스트 및 문서화

  • SignupControllerTest 작성, AuthControllerTest 수정
  • REST Docs 기반 문서 (auth.adoc) 작성

5️⃣ 의존성 추가

  • spring-boot-starter-security, spring-security-test
  • JWT, REST Docs 관련 라이브러리 추가

스크린샷

1748695245435
image

💬 리뷰 요구사항

🙇‍♀️ 구현은 최선을 다해 진행했지만, 코드 흐름에 대한 이해가 부족한 부분이 있습니다.
어색한 로직이 있다면 편하게 코멘트 부탁드립니다 :)

📌 회원가입 중복 실패 테스트와 애플 로그인 토큰 파싱 실패 테스트는 문서화(.andDo(document(...))) 부분에서 오류가 발생해 일단 주석 처리해두었습니다.
테스트 자체는 통과하며, 추후 응답 형식이나 문서 구조를 확인한 뒤 다시 문서화할 예정입니다!

@Dolchae Dolchae self-assigned this May 31, 2025
@Dolchae Dolchae added the 🌟 feat 기능 개발 관련 이슈 label May 31, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Dolchae Dolchae linked an issue May 31, 2025 that may be closed by this pull request
4 tasks
@Hooneybadger Hooneybadger merged commit dec9d58 into dev Jun 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 feat 기능 개발 관련 이슈

Projects

None yet

Development

Successfully merging this pull request may close these issues.

회원가입 구현

2 participants