Skip to content

Fix Windows SD and USB reader flashing - #11

Merged
bestquark merged 3 commits into
mainfrom
agent/fix-windows-sd-readers
Aug 15, 2026
Merged

Fix Windows SD and USB reader flashing#11
bestquark merged 3 commits into
mainfrom
agent/fix-windows-sd-readers

Conversation

@bestquark

Copy link
Copy Markdown
Collaborator

What changed

  • make Windows disk preparation state-aware and idempotent
  • support USB-A, USB-C, native SD, and MMC readers
  • fall back to safely dismounting card volumes when a reader cannot offline the whole disk
  • surface the actual PowerShell error instead of only the failed command
  • add native Windows regression tests and package validation

Root cause

The helper always cleared read-only state and took the disk offline on both preparation passes. At 98.5%, many cards were already offline, and some Windows storage drivers reject a read-only update against an offline disk. Other removable-media drivers do not implement whole-disk offline state at all.

Validation

  • make test
  • Python USB/SD/MMC safety and command regression tests
  • Windows Actions job exercises the PowerShell transitions and builds the packaged helper

@bestquark
bestquark marked this pull request as ready for review August 15, 2026 14:04
@bestquark
bestquark merged commit e04b857 into main Aug 15, 2026
4 checks passed
@bestquark
bestquark deleted the agent/fix-windows-sd-readers branch August 15, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant