Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y adjustments to tech talks page #40

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

mtfoley
Copy link
Contributor

@mtfoley mtfoley commented Jan 9, 2023

This PR resolves #39.

  • adds title attribute to YouTube embeds
  • changes links to black for pink and yellow backgrounds

- adds title attribute to YouTube embeds
- changes links to black for pink and yellow backgrounds
@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for the-collab-lab ready!

Name Link
🔨 Latest commit 378996d
🔍 Latest deploy log https://app.netlify.com/sites/the-collab-lab/deploys/63bb922ca4bf9200084655e9
😎 Deploy Preview https://deploy-preview-40--the-collab-lab.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@segdeha
Copy link
Member

segdeha commented Jan 9, 2023

Hey @mxmason, I got an email from Netlify about this deploy request. Haven’t seen that before. Why would that have happened? @mtfoley is in the TCL org 🤔

@segdeha segdeha requested a review from mxmason January 9, 2023 04:26
@segdeha
Copy link
Member

segdeha commented Jan 9, 2023

Hey @mxmason, I got an email from Netlify about this deploy request. Haven’t seen that before. Why would that have happened? @mtfoley is in the TCL org 🤔

Oh, maybe because it’s from a fork?

@mtfoley, we generally just work together on branches in the main repos. This PR is fine, but in the future feel free to keep it simple!

@mtfoley
Copy link
Contributor Author

mtfoley commented Jan 9, 2023

Got it. If y'all decide you'd rather I make a new one straight from a branch on the main repo, LMK 👀

Copy link
Collaborator

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes, @mtfoley! Merge at your leisure!

@mtfoley mtfoley merged commit c4735aa into the-collab-lab:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tech talks page could use a couple of a11y tweaks
3 participants