Use more contextual variable names, and add inline logical && operator

the-collab-lab · Aug 18, 2024 · 136cf25 · 136cf25
1 parent 26023d4
commit 136cf25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/src/views/Home.jsx b/src/views/Home.jsx
@@ -2,23 +2,22 @@ import './Home.css';
 import { SingleList } from '../components';
 
 export function Home({ data, setListPath }) {
-	const dataPresent = data.length !== 0;
+	const hasList = data.length !== 0;
 	return (
 		<div className="Home">
 			<p>
 				Hello from the home (<code>/</code>) page!
 			</p>
 			<ul>
-				{dataPresent
-					? data.map((list, index) => (
-							<SingleList
-								key={index}
-								name={list.name}
-								path={list.path}
-								setListPath={setListPath}
-							/>
-						))
-					: null}
+				{hasList &&
+					data.map((list, index) => (
+						<SingleList
+							key={index}
+							name={list.name}
+							path={list.path}
+							setListPath={setListPath}
+						/>
+					))}
 			</ul>
 		</div>
 	);

diff --git a/src/views/List.jsx b/src/views/List.jsx
@@ -1,16 +1,15 @@
 import { ListItem } from '../components';
 
 export function List({ data }) {
-	const dataPresent = data.length !== 0;
+	const hasItem = data.length !== 0;
 	return (
 		<>
 			<p>
 				Hello from the <code>/list</code> page!
 			</p>
 			<ul>
-				{dataPresent
-					? data.map((item) => <ListItem key={item.id} name={item.name} />)
-					: null}
+				{hasItem &&
+					data.map((item) => <ListItem key={item.id} name={item.name} />)}
 			</ul>
 		</>
 	);