store: compare labels directly (#7766)

Do not create intermediate prometheus labels and compare the labels directly. Signed-off-by: Giedrius Statkevičius <[email protected]>
thanos-io · Sep 20, 2024 · 30f453e · 30f453e
1 parent 5d36a5a
commit 30f453e
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/store/proxy_merge.go b/pkg/store/proxy_merge.go
@@ -173,10 +173,7 @@ func NewProxyResponseLoserTree(seriesSets ...respSet) *losertree.Tree[*storepb.S
 			return true
 		}
 		if a.GetSeries() != nil && b.GetSeries() != nil {
-			iLbls := labelpb.LabelpbLabelsToPromLabels(a.GetSeries().Labels)
-			jLbls := labelpb.LabelpbLabelsToPromLabels(b.GetSeries().Labels)
-
-			return labels.Compare(iLbls, jLbls) < 0
+			return labelpb.CompareLabels(a.GetSeries().Labels, b.GetSeries().Labels) < 0
 		} else if a.GetSeries() == nil && b.GetSeries() != nil {
 			return true
 		} else if a.GetSeries() != nil && b.GetSeries() == nil {