execution: partial responses in distributed engine #480
Conversation
MichaHoffmann
force-pushed
the
mhoffmann-handle-partial-responses-in-remote-engines
branch
2 times, most recently
from
2f5c05e
to
4fbc06f
Compare
For very distributed setups we need to be able to deal with partial failures. This commit adds an option to continue evaulation if we encounter an error in a remote engine but dont want to fail the whole query. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann-handle-partial-responses-in-remote-engines
branch
from
4fbc06f
to
fbc6e69
Compare
|
I am not sure if this belongs in the engine to be fair. We already have this feature in Thanos so we could convert error responses to warnings when executing remote queries: https://github.com/thanos-io/thanos/blob/main/pkg/query/remote_engine.go#L231 |
Im kinda going back and forth about this in my head, but currently I feel like because the query engine orchestrates all the requests, it is the right place to make decisions about partial responses too. But this is mostly vibe based, just feels better to me right now. |
For very distributed setups we need to be able to deal with partial failures. This commit adds an option to continue evaulation if we encounter an error in a remote engine but dont want to fail the whole query.