#167: Patch GIS province data for Da Nang and Khanh Hoa - #174
Merged
Conversation
thanglequoc
commented
Jul 12, 2026
thanglequoc
commented
Owner
- Apply the manual patch GIS province data for Da Nang and Khanh Hoa to include Spratly and Paracel Islands
- The patching is handle by using the ST_Union function in Postgis to combine the existing GIS province data and the GIS ward of the islands
Merge Hoàng Sa (20333) → Da Nang (48) and Trường Sa (22736) → Khanh Hoa (56) ward-level geometries into their parent province geometries. This fixes an upstream GIS data defect where province-level API responses from sapnhap.bando.com.vn exclude island territories that are present at the ward level. Changes: - sapnhap.go: add PatchIslandProvincesGeometry + mergeWardGeometryIntoProvince methods using inline SQL with ST_Union and ST_Envelope - sapnhap_bando.go: add exported PatchIslandProvincesGeometry() entry point wired into the generation flow after FetchGISDataFromSapNhapBando() - main.go: integrate patch step before GenerateGISSQLDatasets() - sapnhap_test.go: add integration test stub for the patch After the patch, province geometries spatially contain all administrative subdivisions, including the Paracel and Spratly Islands.
Owner
Author
|
Fix verified: Da Nang GIS province Khanh Hoa GIS province |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.