Clean up dataset generation script code - #171
Merged
Merged
Conversation
- Clean up the old GIS data bootstrap code that use the API and response model from the past sapnhap bando site
The gis_comparator package was a one-time validation tool built March 2026 to verify the GIS data migration from the deprecated SAPNhap API. The validation completed successfully (100% match). The package is not imported by main.go and its SQL dump dependencies no longer exist.
The cmd/compare-gis CLI was the only consumer of the gis_comparator package. Both the source and compiled binary are removed.
…ted/ directory The feature doc documented a one-time validation tool that has been removed. The exported/ directory only contained .DS_Store — the SQL dump files it originally held were already deleted.
Remove dead code identified during systematic call-graph analysis: - dvhcvn_model.go: Remove DvhcvnModel (legacy combined model) and DvhcvnDistrictModel structs — zero references in the codebase - dvhcvn_parser.go: Remove toDvhcvnDistrictModel() and extractDistrictDvhcvnUnits() — the DanhMucQuanHuyen SOAP endpoint is never called by FetchDvhcvnData() - data_downloader.go: Remove unused DVHCVN_SOAP_DANH_MUC_QUAN_HUYEN const - testutil/: Delete entire package — TestFixtureLoader had zero imports from any package in the codebase
thanglequoc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up dead code and unused referenced