Skip to content

Commit

Permalink
Merge pull request moby#49123 from akerouanton/remove-dns-answers-fro…
Browse files Browse the repository at this point in the history
…m-otel-spans

[master forward-port] libnet: don't put external DNS answers in OTel spans
  • Loading branch information
thaJeztah authored Dec 18, 2024
2 parents ca85ba2 + 1b823fb commit bdfc384
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions libnetwork/resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,7 @@ func (r *Resolver) forwardExtDNS(ctx context.Context, proto string, remoteAddr n
r.log(ctx).Debugf("[resolver] external DNS %s:%s returned response with no answers:\n%s", proto, extDNS.IPStr, resp)
}
resp.Compress = true
span.AddEvent("response from upstream server", trace.WithAttributes(
attribute.String("libnet.resolver.resp", resp.String()),
))
span.AddEvent("response from upstream server")
return resp
}

Expand Down

0 comments on commit bdfc384

Please sign in to comment.