Added default ModelId for Messages #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Krzysztof318 for the PR! A couple of small asks if possible. Could you add the same functionality to the traditional endpoints (not just the new |
|
Hi, I haven't added Unit tests, because existing tests are more like integration tests due to http client is not mocked. But ok I will add tests to existing tests files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added default ModelID to AnthropicClient.
So if consumer prefer to specify if once with client, not everytime with MessageParameters now has simple way to do this.
The PR won't break or change existing functionallity if consumer won't use new property.
Also added clone method to MessageParameters.