Paginate project listing#4
Open
alesp56 wants to merge 1 commit into
Open
Conversation
tgeselle
approved these changes
Mar 21, 2026
tgeselle
left a comment
Owner
There was a problem hiding this comment.
Clean PR — fixes a real pagination bug with a reusable helper. One suggestion to future-proof it.
| ): Promise<T[]> { | ||
| const results: T[] = []; | ||
| let page = 1; | ||
|
|
Owner
There was a problem hiding this comment.
This while (true) has no upper bound. For project listings it's fine, but as a reusable helper, someone could later use this for events or errors (thousands of pages) and fire unbounded sequential requests.
Consider adding a safety limit:
Suggested change
| let page = 1; | |
| const maxPages = 50; |
Then check page >= maxPages in the loop. A maxPages parameter with a sensible default would also work.
Owner
|
Also — this is missing a version bump in |
|
Can we expect this to be released soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing