Open
Conversation
kurtisc
force-pushed
the
kurtis/durable-storage/verify-resolver
branch
2 times, most recently
from
1945f6f to
da9bc7d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 89.70% 89.71%
=======================================
Files 110 110
Lines 22136 22136
Branches 22136 22136
=======================================
+ Hits 19857 19859 +2
+ Misses 1884 1882 -2
Partials 395 395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kurtisc
force-pushed
the
kurtis/durable-storage/verify-resolver
branch
3 times, most recently
from
8799a96 to
9646f78
Compare
Adds implementations of `Resolver` and `FromProof` for IDs used for implementing `Verify` mode for the Merkle layer.
kurtisc
force-pushed
the
kurtis/durable-storage/verify-resolver
branch
from
9646f78 to
1134f2a
Compare
kurtisc
requested review from
NSant215,
emturner,
jobjo,
thomasathorne,
vapourismo,
victor-dumitrescu and
zcabter
as code owners
|
Benchmark results for revision b182284:
Full results
Compare the results above with those for the default branch. |
vapourismo
requested changes
Mar 30, 2026
|
|
||
| /// Identifier for a tree resolved in [`Verify`] mode. | ||
| pub enum VerifyTreeId { | ||
| Present(Tree<Arc<VerifyNodeId>>), |
Collaborator
There was a problem hiding this comment.
Let's keep the reference counting in the node/node ID, like LazyNodeId and ArcNodeId.
| } | ||
| } | ||
|
|
||
| impl Resolver<VerifyTreeId, Tree<Arc<VerifyNodeId>>> for VerifyResolver { |
Collaborator
There was a problem hiding this comment.
Something doesn't add up here. Resolving VerifyTreeId -> Tree<Arc<VerifyNodeId>> implies that Arc<VerifyNodeId> is a node ID, but it's not. The Arc prevents it.
NSant215
reviewed
Mar 30, 2026
| } | ||
| } | ||
|
|
||
| /// Identifier for a node resolved in [`Verify`] mode. |
Contributor
There was a problem hiding this comment.
perhaps worth a comment about why Absent doesn't exist
vapourismo
reviewed
Mar 30, 2026
Comment on lines
+561
to
+573
| let (ctx, present) = ctx.next_branch_with(|proof| proof.into_leaf::<bool>())?; | ||
| match present { | ||
| Partial::Present(true) => { | ||
| let (ctx, node_id) = ctx.next_branch_with(|proof| { | ||
| let suspended = VerifyNodeId::from_proof(proof)?; | ||
| Ok(suspended.map(Arc::new)) | ||
| })?; | ||
| ctx.done(VerifyTreeId::Present(Tree::from(Some(node_id)))) | ||
| } | ||
| Partial::Present(false) => ctx.done(VerifyTreeId::Present(Tree::default())), | ||
| // SAFETY: called only in `Verify` mode | ||
| Partial::Blinded(_) | Partial::Absent => unsafe { not_found() }, | ||
| } |
Collaborator
There was a problem hiding this comment.
This portion should be done by the parser (not necessarily FromProof) for Tree. I think the VerifyTreeId type doesn't need to implement on behalf of Tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-949
What
Adds support for parsing MAVL tree proofs for
VerifymodeWhy
This is needed as part of supporting
Verifymode in the Merkle layer.How
VerifyNodeId/VerifyTreeIdResolverfor eachManually Testing
Tasks for the Author