refactor(durable-storage): hashing the MerkleLayer cannot fail#956
Merged
vapourismo merged 1 commit intomainfrom Mar 30, 2026
Merged
refactor(durable-storage): hashing the MerkleLayer cannot fail#956vapourismo merged 1 commit intomainfrom
vapourismo merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 89.82% 89.76% -0.06%
==========================================
Files 123 123
Lines 26469 26455 -14
Branches 26469 26455 -14
==========================================
- Hits 23775 23747 -28
- Misses 2082 2097 +15
+ Partials 612 611 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8efe42f to
f62fc1b
Compare
6768542 to
488d4cd
Compare
f62fc1b to
2575952
Compare
|
Benchmark results for revision c16766d:
Full results
Compare the results above with those for the default branch. |
kurtisc
approved these changes
Mar 27, 2026
NSant215
approved these changes
Mar 27, 2026
488d4cd to
937aaab
Compare
2575952 to
49d0d68
Compare
937aaab to
d077284
Compare
442622e to
948a552
Compare
d077284 to
8aee2fb
Compare
948a552 to
3ff890b
Compare
6eb9a7a to
4c31640
Compare
3ff890b to
1100206
Compare
1100206 to
86f9324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the fallibility from hashing operations in the Merkle layer.
Why
These operations can't fail.
Manually Testing
Tasks for the Author