Skip to content

refactor(durable-storage): hashing the MerkleLayer cannot fail#956

Merged
vapourismo merged 1 commit intomainfrom
ole/push-twtuzkozsuxw
Mar 30, 2026
Merged

refactor(durable-storage): hashing the MerkleLayer cannot fail#956
vapourismo merged 1 commit intomainfrom
ole/push-twtuzkozsuxw

Conversation

@vapourismo
Copy link
Copy Markdown
Collaborator

@vapourismo vapourismo commented Mar 26, 2026

What

Remove the fallibility from hashing operations in the Merkle layer.

Why

These operations can't fail.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (be8ca56) to head (86f9324).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   89.82%   89.76%   -0.06%     
==========================================
  Files         123      123              
  Lines       26469    26455      -14     
  Branches    26469    26455      -14     
==========================================
- Hits        23775    23747      -28     
- Misses       2082     2097      +15     
+ Partials      612      611       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from 8efe42f to f62fc1b Compare March 26, 2026 21:17
@vapourismo vapourismo force-pushed the ole/push-wzvrzrvmuupp branch from 6768542 to 488d4cd Compare March 26, 2026 21:17
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from f62fc1b to 2575952 Compare March 26, 2026 21:18
@vapourismo vapourismo marked this pull request as ready for review March 26, 2026 21:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Benchmark results for revision c16766d:

Metric Duration TPS
Mean 1.516251168s 26.381
Worst 1.528160921s 26.175
Best 1.508351464s 26.519
Standard Deviation ±5.803951ms ±0.101
Full results
Run Transfers Duration TPS
1 40 1.526476497s 26.204
2 40 1.518827593s 26.336
3 40 1.518750068s 26.337
4 40 1.517364492s 26.361
5 40 1.50975476s 26.494
6 40 1.515971579s 26.386
7 40 1.514740876s 26.407
8 40 1.508523086s 26.516
9 40 1.5171165s 26.366
10 40 1.518872417s 26.335
11 40 1.511843973s 26.458
12 40 1.528160921s 26.175
13 40 1.51133967s 26.467
14 40 1.526979866s 26.195
15 40 1.515012876s 26.402
16 40 1.509778436s 26.494
17 40 1.515512651s 26.394
18 40 1.520059051s 26.315
19 40 1.511586578s 26.462
20 40 1.508351464s 26.519

Compare the results above with those for the default branch.

@vapourismo vapourismo force-pushed the ole/push-wzvrzrvmuupp branch from 488d4cd to 937aaab Compare March 27, 2026 18:52
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from 2575952 to 49d0d68 Compare March 27, 2026 18:52
@vapourismo vapourismo force-pushed the ole/push-wzvrzrvmuupp branch from 937aaab to d077284 Compare March 27, 2026 18:52
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch 2 times, most recently from 442622e to 948a552 Compare March 30, 2026 09:19
@vapourismo vapourismo force-pushed the ole/push-wzvrzrvmuupp branch from d077284 to 8aee2fb Compare March 30, 2026 09:19
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from 948a552 to 3ff890b Compare March 30, 2026 12:19
@vapourismo vapourismo force-pushed the ole/push-wzvrzrvmuupp branch 2 times, most recently from 6eb9a7a to 4c31640 Compare March 30, 2026 13:18
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from 3ff890b to 1100206 Compare March 30, 2026 13:19
Base automatically changed from ole/push-wzvrzrvmuupp to main March 30, 2026 15:02
@vapourismo vapourismo force-pushed the ole/push-twtuzkozsuxw branch from 1100206 to 86f9324 Compare March 30, 2026 15:46
@vapourismo vapourismo enabled auto-merge March 30, 2026 15:46
@vapourismo vapourismo added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 63c2b04 Mar 30, 2026
8 checks passed
@vapourismo vapourismo deleted the ole/push-twtuzkozsuxw branch March 30, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants