refactor(pvm): group Tezos-related fields into new struct#952
Merged
victor-dumitrescu merged 2 commits intomainfrom Apr 1, 2026
Merged
refactor(pvm): group Tezos-related fields into new struct#952victor-dumitrescu merged 2 commits intomainfrom
victor-dumitrescu merged 2 commits intomainfrom
Conversation
|
Benchmark results for revision 523eab3:
Full results
Compare the results above with those for the default branch. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (72.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
- Coverage 89.77% 89.69% -0.08%
==========================================
Files 123 123
Lines 26452 26472 +20
Branches 26452 26472 +20
==========================================
- Hits 23747 23745 -2
- Misses 2094 2111 +17
- Partials 611 616 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d737b40 to
383ea65
Compare
383ea65 to
1363d6a
Compare
b4c527f to
0d6d69c
Compare
emturner
reviewed
Apr 1, 2026
kurtisc
approved these changes
Apr 1, 2026
897bf0f to
ddd032a
Compare
ddd032a to
b752440
Compare
emturner
approved these changes
Apr 1, 2026
thomasathorne
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-909.
What
This PR changes the PVM state, grouping all the Tezos-specific state components under a new
Tezosstruct.Why
Simplifies the signature of functions operating on Tezos-related state components. Allows certain outbox functions to be implemented directly on
Tezosonly instead of the whole PVM state.How
The
Tezosstruct is introduced, as well as implementations for all the traits needed for it to be used as part of the PVM state. These implementations and the changes across the PVM codebase are mostly mechanical.Manually Testing
Regressions
Encoding and proof format have changed, requiring refreshing all regressions.
This change causes a small but consistent performance hit, which is acceptable for now.
Tasks for the Author