Skip to content

refactor(pvm): group Tezos-related fields into new struct#952

Merged
victor-dumitrescu merged 2 commits intomainfrom
vdum/rv-909
Apr 1, 2026
Merged

refactor(pvm): group Tezos-related fields into new struct#952
victor-dumitrescu merged 2 commits intomainfrom
vdum/rv-909

Conversation

@victor-dumitrescu
Copy link
Copy Markdown
Contributor

@victor-dumitrescu victor-dumitrescu commented Mar 26, 2026

Closes RV-909.

What

This PR changes the PVM state, grouping all the Tezos-specific state components under a new Tezos struct.

Why

Simplifies the signature of functions operating on Tezos-related state components. Allows certain outbox functions to be implemented directly on Tezos only instead of the whole PVM state.

How

The Tezos struct is introduced, as well as implementations for all the traits needed for it to be used as part of the PVM state. These implementations and the changes across the PVM codebase are mostly mechanical.

Manually Testing

make all

Regressions

Encoding and proof format have changed, requiring refreshing all regressions.

This change causes a small but consistent performance hit, which is acceptable for now.

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@victor-dumitrescu victor-dumitrescu changed the title Vdum/rv 909 refactor(pvm): group Tezos-related fields into new struct Mar 26, 2026
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Benchmark results for revision 523eab3:

Metric Duration TPS
Mean 1.527055905s 26.194
Worst 1.538842501s 25.994
Best 1.521329101s 26.293
Standard Deviation ±4.294283ms ±0.074
Full results
Run Transfers Duration TPS
1 40 1.538842501s 25.994
2 40 1.528061499s 26.177
3 40 1.528727777s 26.166
4 40 1.529487308s 26.153
5 40 1.528331706s 26.172
6 40 1.529387309s 26.154
7 40 1.522124483s 26.279
8 40 1.529027877s 26.160
9 40 1.531927225s 26.111
10 40 1.523944287s 26.248
11 40 1.524384468s 26.240
12 40 1.523507577s 26.255
13 40 1.521599218s 26.288
14 40 1.525057191s 26.229
15 40 1.529163475s 26.158
16 40 1.521545585s 26.289
17 40 1.521329101s 26.293
18 40 1.525701434s 26.217
19 40 1.526588596s 26.202
20 40 1.532379485s 26.103

Compare the results above with those for the default branch.

@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 72.09302% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (7f598fc) to head (b752440).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pvm/src/pvm/tezos.rs 63.54% 17 Missing and 18 partials ⚠️
pvm/src/pvm/common.rs 81.63% 5 Missing and 4 partials ⚠️
pvm/src/pvm/node_pvm.rs 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   89.77%   89.69%   -0.08%     
==========================================
  Files         123      123              
  Lines       26452    26472      +20     
  Branches    26452    26472      +20     
==========================================
- Hits        23747    23745       -2     
- Misses       2094     2111      +17     
- Partials      611      616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from vdum/level_is_option to main March 26, 2026 14:53
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 26, 2026
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 27, 2026
@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 27, 2026
@victor-dumitrescu victor-dumitrescu force-pushed the vdum/rv-909 branch 2 times, most recently from b4c527f to 0d6d69c Compare March 31, 2026 15:18
@victor-dumitrescu victor-dumitrescu added the benchmark-trigger Force benchmark run for a PRs label Mar 31, 2026
@github-actions github-actions bot removed the benchmark-trigger Force benchmark run for a PRs label Mar 31, 2026
@victor-dumitrescu victor-dumitrescu marked this pull request as ready for review March 31, 2026 15:23
@victor-dumitrescu victor-dumitrescu force-pushed the vdum/rv-909 branch 2 times, most recently from 897bf0f to ddd032a Compare April 1, 2026 09:56
@victor-dumitrescu victor-dumitrescu added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 9ed92fa Apr 1, 2026
8 of 9 checks passed
@victor-dumitrescu victor-dumitrescu deleted the vdum/rv-909 branch April 1, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants