Draft: using PersistenceLayer in pvm storage#838
Draft
thomasathorne wants to merge 1 commit intomainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (57.81%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 91.14% 91.07% -0.07%
==========================================
Files 111 112 +1
Lines 21288 21258 -30
Branches 21288 21258 -30
==========================================
- Hits 19402 19360 -42
+ Misses 1508 1507 -1
- Partials 378 391 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
996a2d4 to
0ac59a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TZX-72
What
This PR adds the persistence layer to the PVM storage without changing the chunking logic at all.
After implementing, we decided this is not an improvement and it would be better to restructure the PVM storage before switching to using the persistence layer. This branch is useful for testing though, so I've created this PR as a draft.
Why
We will switch to the persistence layer at some point, though it won't look exactly like this.
How
This branch takes the path of least refactoring, so the
chunked_iomodule is left basically untouched. TheStoreis turned into a wrapper around the persistence layer and theRepois turned into a wrapper aroundDirectoryManager.Manually Testing
Tasks for the Author