fix(dependencies): update outdated dependencies and tests #78
Conversation
|
@kentcdodds, @brunohkbx, @thymikee Sorry for bothering you folks, pulled your names from #31 is there any chance we could get this PR looked at? Things in here have become pretty stale and even things like #77 are currently blocked. |
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 149 149
Branches 48 48
=========================================
Hits 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Awesome work @Alex-Whyatt 🚀
It seems that codecov complains about to-contain-elements.js coverage and hence blocks the potential merging. Would you be able to look at it as well? Should be a small case of adding one or two test cases to achieve missing line 31 coverage.
Alex-Whyatt
force-pushed
the
fix-deps-update-tests
branch
from
5aaa228 to
1097aa3
Compare
|
Code coverage is happier now locally. Not sure what was causing it as it occurred in unaffected files. Should be good to go pending approval @mdjastrzebski |
|
Code Coverage also happy on CI! @Alex-Whyatt Thank you for your contribution! |
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Updates critically outdated dependencies, including @babel/runtime, which was responsible for failing tests on the main branch. Updates tests where required, in line with newly required props or required child elements.
Why:
Tests faililng on master, jest-diff version 24.x was causing issues for us when we tried to upgrade jest.
How:
Carefully upgrading the dependencies affected to a newer version and fixing the affected test files.
Checklist:
docs
The only possibly breaking change I occurred here is that the button <title> prop could no longer be found by the toHaveProp function. I suspect this was due to this text being moved into the components "children" by react-test-renderer.
ToBeEnabled/Disabled has removed accessibilityStates testing as they have been removed callstack/react-native-paper#1920.
Minor change in toHaveStyle because jest-diff removed their default export.