fix: declare .finally(...) usages as handled in async rules
#1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonkevin
changed the title
await-async-* handles finallyawait-async-* declare .finally(...) usages as handled
bonkevin
force-pushed
the
await-async-finally
branch
from
46c8280 to
a461070
Compare
bonkevin
force-pushed
the
await-async-finally
branch
from
a461070 to
0626757
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 50 50
Lines 2679 2680 +1
Branches 1099 1099
=======================================
+ Hits 2583 2584 +1
Misses 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
changed the title
await-async-* declare .finally(...) usages as handled.finally(...) usages as handled
Belco90
changed the title
.finally(...) usages as handled.finally(...) usages as handled in async rules
|
🎉 This PR is included in version 7.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @bonkevin for code and test |
|
I've put up a pull request to add @bonkevin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
await-async-queries&await-async-utils:.finally(...)usages declare the promise as handledContext
Following #1059 changes that added
.catchcompatibility toawait-async-queriesandawait-async-utils, this PR handles.finallyusages.