Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run with Node.js 20 #1263

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 16, 2023

Current Node.js release that will go into LTS next month

@MatanBobi
Copy link
Member

This was already done as part of #1255 which is merged to alpha,
is there any specific reason to have another pr?

@eps1lon
Copy link
Member Author

eps1lon commented Sep 17, 2023

To have it in main. #1255 also drops support for Node.js 14 which I don't want to do. We can package that with actual features but I see no reason releasing a Major with just Node.js 14 support dropped. That seems kind of boring.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d14849:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #1263 (5d14849) into main (07f5999) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       351       351           
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)
node-20 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon marked this pull request as ready for review September 17, 2023 19:31
@eps1lon eps1lon merged commit a7b7252 into testing-library:main Oct 1, 2023
7 checks passed
@eps1lon eps1lon deleted the test/node-20 branch October 1, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants