-
Notifications
You must be signed in to change notification settings - Fork 8
Add Copy blob to client and use in compose when composing a new blob from a single blob #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… passed a single source key
Looks good! Thank you for the contribution! Any reason for using put blob from url instead of copy blob from url? Copy blob is async, but copy blob from url is synchronous and would unblock 256MB limit instead of 5MB. I did some testing by omitting We'll need a changelog entry too. Thank you! |
I originally was using Even though If you feel that this is too much of a risk for this library, i.e. using |
@JoeDupuis what do you think about me adding an |
Oh! I misread that—5000MiB, not 5MiB! 😅 Sorry for the late reply! I've been quite busy since the start of the year. I'm not too worried about timeouts for 256MiB copies, but I should really look into adding an option to change the timeout (not in this PR). I don't think we need an option for cases under 256MiB. Larger copies might require it, as they would also need a longer timeout. Do you use compose just to copy single files, or do you also do "true" multi-file compose? If it's just single-file copies and you have a lot of larger files (3GB+), perhaps using the AzureBlob client directly for copying would make sense. The configured client is accessible from the AzureBlobService, so hopefully the interface won't be too rough. I know you can't do that now (copy bigger files) because of the timeout, but this should be configurable—I'll look into it. Pretty cool to see the NML is using the gem! Hopefully I am not about to have my name on the git blame of some apocalyptic event 😂 |
Co-authored-by: Joé Dupuis <[email protected]>
Thank you! I just released you changes in 0.5.7 |
Awesome, thanks I'll switch over our dependency to this release from our fork.
We use |
In our app we wanted to reduce data handling in
compose
when only a single source blob is provided. To reduce data handling, I have added in support forcopy-blob
.Now
compose
has slightly different behaviour. When a single source key is specified, thecompose
method will instead usecopy-blob
operation, otherwise the existing behaviour remains.