-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copy blob to client and use in compose when composing a new blob from a single blob #15
base: main
Are you sure you want to change the base?
Conversation
… passed a single source key
Looks good! Thank you for the contribution! Any reason for using put blob from url instead of copy blob from url? Copy blob is async, but copy blob from url is synchronous and would unblock 256MB limit instead of 5MB. I did some testing by omitting We'll need a changelog entry too. Thank you! |
I originally was using Even though If you feel that this is too much of a risk for this library, i.e. using |
@JoeDupuis what do you think about me adding an |
In our app we wanted to reduce data handling in
compose
when only a single source blob is provided. To reduce data handling, I have added in support forcopy-blob
.Now
compose
has slightly different behaviour. When a single source key is specified, thecompose
method will instead usecopy-blob
operation, otherwise the existing behaviour remains.