-
Notifications
You must be signed in to change notification settings - Fork 310
chore: Update pyproject and tests to support Mac's/arm local development #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terry-docker
wants to merge
7
commits into
testcontainers:main
Choose a base branch
from
terry-docker:support-arm-local-development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: Update pyproject and tests to support Mac's/arm local development #814
terry-docker
wants to merge
7
commits into
testcontainers:main
from
terry-docker:support-arm-local-development
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which seems to work with ibm specifically
b1cf47a
to
7c4d4c8
Compare
ambitda
previously approved these changes
May 7, 2025
alexanderankin
approved these changes
May 7, 2025
f555efe
to
7522fbf
Compare
7522fbf
to
28d7024
Compare
1f2c17b
to
8cdd6c8
Compare
terry-docker
commented
May 12, 2025
Comment on lines
+28
to
+35
- name: Display Docker and Compose Versions | ||
run: | | ||
@echo "##[group]Docker Version" | ||
@docker --version || echo "Docker is not installed or misconfigured" | ||
@echo "##[endgroup]" | ||
@echo "##[group]Docker Compose Version" | ||
@docker compose version || docker-compose --version || echo "Docker Compose is not installed or misconfigured" | ||
@echo "##[endgroup]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to workflow command to help with debugging docker errors in the checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to help contribute to testcontainers-python but issues getting the local environment running. Starting off with fixing the install + test suite so myself and other people on Mac can get up and running faster.
Manual testing done:
This branch was tested on a few different Mac machines the and a Linux VM (still on arm).
make install
andmake tests
checked in all envs, I also checked docs, build, and cleans on the Linux VM and a M2 mac.Notes:
Ticket:
#813