Skip to content

Refactor of timeouts #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

digital88
Copy link
Contributor

#960

  • Added class Ms which provides conversion from ms to nanos and seconds.
  • Explicitly call this class' conversion methods when calling Docker APIs. Example:
...
log.debug(`Stopping container...`, { containerId: container.id });
const t = new Ms(opts?.timeout ?? 0).seconds();
await container.stop({ t });
...
  • Renamed parameters in all public APIs to tell that value in ms expected to be passed.
  • Renamed some internal fields and methods to tell that value in ms expected there.
  • Added docs for timeouts.
  • Updated old docs where timeouts are used.

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 6069d7b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67e404520c6bff000842394f
😎 Deploy Preview https://deploy-preview-962--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request major An incompatible API change labels Mar 26, 2025
@cristianrgreco cristianrgreco added this to the 11.0.0 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major An incompatible API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants