[Azure AI - Health Insights] - Typespec revision for Health Insights API V3 (Radiology Insights) #3214

mikeharder · 2024-02-08T22:31:29Z

Copy of Azure/azure-rest-appi-specs#27614 for testing

This reverts commit b238f6f.

…specs into asaflevi/healthinsights-radiologyinsights-api-v3

openapi-pipeline-app-test · 2024-02-08T22:31:34Z

Next Steps to merge

Next steps that must be taken to merge this PR:

❌ Your PR requires an API stewardship board review. See the PR description for help.
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app-test · 2024-02-08T22:31:34Z

Swagger Generation Artifacts

️🔄~[NotRequired_Staging] ApiDocPreview inProgress [Detail]

️❌ azure-sdk-for-python failed [Detail]

❌Code Generator Failed [Logs] Generate from e7fb5d59c131bdd5c645f8d04da615ebad2e675b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/ai/data-plane/HealthInsights/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
warn		specification/ai/HealthInsights/HealthInsights.OpenAPI/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from e7fb5d59c131bdd5c645f8d04da615ebad2e675b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] ime  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:--- 1195k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ############################## 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New major version of npm available! 9.5.0 -> 10.4.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[init.sh] npm notice
warn		specification/ai/data-plane/HealthInsights/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
warn		specification/ai/HealthInsights/HealthInsights.OpenAPI/tspconfig.yaml skipped due to azure-sdk-for-java not found in tspconfig.yaml
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] warning: typespec-java - Rename TypeSpec Model 'Record<unknown>' to 'Record' @ unknown
cmderr	[generate.py] warning: typespec-java - Rename anonymous TypeSpec Model to 'ResearchStudyArm' @ unknown
cmderr	[generate.py] warning: typespec-java - Rename anonymous TypeSpec Model to 'ResearchStudyObjective' @ unknown
cmderr	[generate.py] warning: in the working copy of 'sdk/healthinsights/azure-health-insights-radiologyinsights/pom.xml', CRLF will be replaced by LF the next time Git touches it
cmderr	[generate.py] warning: in the working copy of 'sdk/healthinsights/azure-health-insights-radiologyinsights/pom.xml', CRLF will be replaced by LF the next time Git touches it

️✔️azure-health-insights-radiologyinsights [View full logs] [Preview SDK Changes]

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from e7fb5d59c131bdd5c645f8d04da615ebad2e675b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/ai/data-plane/HealthInsights/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
warn		specification/ai/HealthInsights/HealthInsights.OpenAPI/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1]
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Run `npm install -g [email protected]` to update!
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 141 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m

❌Azure.Health.Insights.RadiologyInsights [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e7fb5d59c131bdd5c645f8d04da615ebad2e675b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
warn		specification/ai/data-plane/HealthInsights/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
warn		specification/ai/HealthInsights/HealthInsights.OpenAPI/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure-rest/health-insights-radiologyinsights [View full logs] [Preview SDK Changes]
- azure-rest-health-insights-radiologyinsights-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app-test · 2024-02-08T22:31:35Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-health-insights-radiologyinsights	https://apiviewuxtest.com/Assemblies/Review/c48b47bd12a6493aa27b2cec58f9e54e?revisionId=eca09c6b40824052acfb9a5617363057
JavaScript	@azure-rest/health-insights-radiologyinsights	Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger	HealthInsights	https://apiviewuxtest.com/Assemblies/Review/0aef26c4ab2c438db6b3089e208c348c?revisionId=9a83e8c528604bde92caa93fb81292dc
TypeSpec	HealthInsights.OpenAPI	https://apiviewuxtest.com/Assemblies/Review/652055157260479f95c0f6ec96285993?revisionId=cf438dd6c59547b0afbbea1761cc8d55

openapi-pipeline-app-test · 2024-02-08T22:31:35Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 31 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
openapi.json	2024-04-01(7419401)	2023-09-01-preview(main)

The following breaking changes are detected by comparison with latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/onco-phenotype/jobs' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L64:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/onco-phenotype/jobs/{id}' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L198:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/patient-timeline/jobs' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L253:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/patient-timeline/jobs/{id}' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L387:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/radiology-insights/jobs' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L442:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/trial-matcher/jobs' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L631:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/trial-matcher/jobs/{id}' removed or restructured? Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L765:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ClinicalTrials' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'OncoPhenotypeData' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'OncoPhenotypeModelConfiguration' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'PatientTimelineData' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'PatientTimelineModelConfiguration' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'TrialMatcherData' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'TrialMatcherModelConfiguration' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L260:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L821:3
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'Azure.Core.RepeatabilityRequestHeaders.repeatabilityFirstSent' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L3025:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4867:3
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'Azure.Core.RepeatabilityRequestHeaders.repeatabilityRequestId' removed or renamed? New: HealthInsights/stable/2024-04-01/openapi.json#L3025:3 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4867:3
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: HealthInsights/stable/2024-04-01/openapi.json#L103:13 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L600:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: HealthInsights/stable/2024-04-01/openapi.json#L2756:9 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4431:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: HealthInsights/stable/2024-04-01/openapi.json#L2512:11 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L3996:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: HealthInsights/stable/2024-04-01/openapi.json#L67:11 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L588:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: HealthInsights/stable/2024-04-01/openapi.json#L2756:9 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4431:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: HealthInsights/stable/2024-04-01/openapi.json#L2756:9 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4431:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'createdDateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2742:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4430:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'expirationDateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2742:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4430:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'lastUpdateDateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2742:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L4430:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'dateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2022:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L3140:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'effectiveDateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2056:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L3174:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'createdDateTime' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2426:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L3882:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'info' renamed or removed? New: HealthInsights/stable/2024-04-01/openapi.json#L2499:7 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L3983:7
⚠️ 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: HealthInsights/stable/2024-04-01/openapi.json#L67:11 Old: HealthInsights/preview/2023-09-01-preview/openapi.json#L588:11

️⚠️LintDiff: 11 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.7)	new version	base version
2024-04-01	2024-04-01(7419401)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L103
⚠️ PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'RadiologyInsights_CreateJob' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema' Location: HealthInsights/stable/2024-04-01/openapi.json#L138
⚠️ OperationId	OperationId for put method should contain both 'Create' and 'Update' Location: HealthInsights/stable/2024-04-01/openapi.json#L139
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L186
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L194
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L217
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L2417
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L2505
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L2597
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L2743
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L2802

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ SecurityDefinitionDescription	Security definition should have a description. Location: HealthInsights/stable/2024-04-01/openapi.json#L43
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L271
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L305
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L318
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L425
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L425
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L438
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L438
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L608
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L634
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L656
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L683
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L789
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L789
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L795
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L809
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L832
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L859
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L913
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L955
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L970
⚠️ AdditionalPropertiesAndProperties	Don't specify additionalProperties as a sibling of properties. Location: HealthInsights/stable/2024-04-01/openapi.json#L994
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L999
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L1016
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/stable/2024-04-01/openapi.json#L1036
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L1084
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L1119
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L1158
⚠️ SchemaNamesConvention	Schema name should be Pascal case. Location: HealthInsights/stable/2024-04-01/openapi.json#L1181
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/stable/2024-04-01/openapi.json#L1243

️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

mikeharder · 2024-02-08T23:09:46Z

/azp run

azure-pipelines · 2024-02-08T23:09:53Z

Azure Pipelines successfully started running 1 pipeline(s).

praveenkuttappan · 2024-02-09T19:16:38Z

/azp run

azure-pipelines · 2024-02-09T19:16:46Z

Azure Pipelines successfully started running 1 pipeline(s).

specification/ai/data-plane/HealthInsights/readme.md

asaflevi-ms added 26 commits February 1, 2024 12:27

V3 - remove OncoPhenotype, TrialMatcher, PatientTimeline interfaces

1285e5e

update readme file

df97c8c

remove client.tsp from all models except RadiologyInsights

b238f6f

Revert "remove client.tsp from all models except RadiologyInsights"

9a9168d

This reverts commit b238f6f.

revert and return client.tsp files

db33fc2

Merge branch 'main' of https://github.com/asaflevi-ms/azure-rest-api-…

7135f60

…specs into asaflevi/healthinsights-radiologyinsights-api-v3

Merge branch 'main' of https://github.com/asaflevi-ms/azure-rest-api-…

c2b476a

…specs into asaflevi/healthinsights-radiologyinsights-api-v3

remove version dependency, also remove all other models except RI

a0c0d83

Fix: request example

b3bc545

prettier

a7dc6db

remove model RadiologyInsightsResult

63bf0a8

remove deprecated operation templates

1625080

move imports to main.tsp

3e01196

add imports to rout.radiologyinsights

a587d83

revert - remove imports from rout file

d91f484

rename patientInfo

f2a5a18

add expand trait

f014297

update example with details property

b3de133

add imports to rout.radiologyinsights

c984b63

fix: API Stewardship board review comments

71ef87a

fix: tsv

fcc65bb

prettier

182ae9e

communication.communicatedAt , recommendation.effectiveAt

59ace56

expand format csv

21e1855

comments

87bc77d

fix: tsv

7f404bc

AzureRestAPISpecReview added data-plane new-api-version TypeSpec labels Feb 8, 2024

praveenkuttappan reviewed Feb 10, 2024

View reviewed changes

specification/ai/data-plane/HealthInsights/readme.md Outdated Show resolved Hide resolved

Update specification/ai/data-plane/HealthInsights/readme.md

7419401

konrad-jamrozik force-pushed the main branch from 6f9f31c to d8e7a99 Compare February 22, 2024 23:02

mikeharder closed this Apr 18, 2024

mikeharder deleted the mikeharder/healthinsights-radiologyinsights-api-v3 branch April 18, 2024 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Azure AI - Health Insights] - Typespec revision for Health Insights API V3 (Radiology Insights) #3214

[Azure AI - Health Insights] - Typespec revision for Health Insights API V3 (Radiology Insights) #3214

Uh oh!

mikeharder commented Feb 8, 2024

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

Uh oh!

mikeharder commented Feb 8, 2024

Uh oh!

azure-pipelines bot commented Feb 8, 2024

Uh oh!

praveenkuttappan commented Feb 9, 2024

Uh oh!

azure-pipelines bot commented Feb 9, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Azure AI - Health Insights] - Typespec revision for Health Insights API V3 (Radiology Insights) #3214

[Azure AI - Health Insights] - Typespec revision for Health Insights API V3 (Radiology Insights) #3214

Uh oh!

Conversation

mikeharder commented Feb 8, 2024

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to merge

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-pipeline-app-test bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

mikeharder commented Feb 8, 2024

Uh oh!

azure-pipelines bot commented Feb 8, 2024

Uh oh!

praveenkuttappan commented Feb 9, 2024

Uh oh!

azure-pipelines bot commented Feb 9, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Feb 8, 2024 •

edited

Loading