Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove test-kitchen dependency #502

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Stromweld
Copy link
Contributor

Description

Allows support for Chef's new chef-test-kitchen-enterprise

Type of Change

Our release process assumes you are using Conventional Commit messages.

The most important prefixes you should have in mind are:

  • _fix_: which represents bug fixes, and correlates to a SemVer patch.
  • _feat_: which represents a new feature, and correlates to a SemVer minor.
  • _feat!_:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.

If you have not included a conventional commit message this can be fixed on merge.

Check List

Signed-off-by: Corey Hemminger <[email protected]>
@damacus damacus self-assigned this Feb 5, 2025
@damacus damacus marked this pull request as draft February 5, 2025 18:24
@damacus
Copy link
Contributor

damacus commented Feb 5, 2025

Converting to draft until we can discuss the implications of this as a group.

Comment on lines 19 to 20

gem.add_dependency "test-kitchen", ">= 1.4", "< 4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this maybe be worked around on your environment with an environment variable? Perhaps something like this:

unless ENV['CHEF_TEST_KITCHEN_ENTERPRISE']
  gem.add_dependency "test-kitchen", ">= 1.4", "< 4"
end

I'm not sure if this will work but it's a thought. By default I'd like to keep this dependency if possible.

Will the other gem be published on rubygems.org or only in a private repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't think of that. Then could do if statement ENV true gem ctke else tk. Does that mean though that whever the vagrant gem is used with ctke that they'd need to set that attribute to true or only when doing something like gem or bundle install?

Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld Stromweld requested review from ramereth and damacus February 7, 2025 22:00
@Stromweld Stromweld self-assigned this Feb 7, 2025
Signed-off-by: Corey Hemminger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants