Addition of two angular constraints #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Removed trajectory file writing items to be placed in a separate branch.
Levi-Armstrong
requested changes
Aug 16, 2018
| VectorXd operator()(const VectorXd& dof_vals) const; | ||
| }; | ||
|
|
||
| enum Axis { |
There was a problem hiding this comment.
Need to namespace the enum see here
There was a problem hiding this comment.
Are we using C++11? Could use enum class instead.
| }; | ||
|
|
||
| /** | ||
| * @brief The ConfinedAxisErrCalculator is a truct whose operator() calculates error of a given |
|
|
||
| /** | ||
| * @brief The ConfinedAxisErrCalculator is a truct whose operator() calculates error of a given | ||
| * pose with respect ot the confined rotation along the defined axis. |
| link_(link), | ||
| tcp_(tcp), | ||
| axis_(axis), | ||
| tol_(tol_angle * M_PI / 180.0) |
| * @param env | ||
| * @param link | ||
| * @param axis Axis of rotation | ||
| * @param tol_angle Tolerance in radians |
There was a problem hiding this comment.
Add a note that this is a +/- range
| Eigen::Affine3d tcp; /**< Tool center point */ | ||
|
|
||
| Axis axis; /**< Axis given a conical tolerance */ | ||
| double tol; /**< Cone angle in degrees */ |
| Eigen::Affine3d tcp; /**< Tool center point */ | ||
|
|
||
| Axis axis; /**< Axis allowed to rotate */ | ||
| double tol; /**< Rotation acceptable in degrees */ |
trajopt/src/kinematic_terms.cpp
Outdated
| VectorXd err(1); | ||
|
|
||
| // determine the error of the rotation | ||
| switch(axis_) { |
trajopt/src/kinematic_terms.cpp
Outdated
| return err; | ||
| } | ||
|
|
||
| VectorXd ConicalAxisErrCalculator::operator()(const VectorXd& dof_vals) const { |
trajopt/src/kinematic_terms.cpp
Outdated
| VectorXd err(1); | ||
|
|
||
| // determine the error of the conical axis | ||
| switch(axis_) { |
…o AlignedAxis. AlignedAxis is currently not interacting consistently with positional constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from the earlier pull request. Removed the file writing functionality and refactored some code.