Tesla control windows #212
Merged
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CLI windows-vent and windows-close commands.
aaronpkahn
reviewed
Mar 11, 2024
pkg/proxy/command.go
Outdated
| case "close": | ||
| return func(v *vehicle.Vehicle) error { return v.CloseWindows(ctx) }, nil | ||
| default: | ||
| return nil, errors.New("command must be 'vent' or 'open'") |
added 2 commits
March 11, 2024 15:38
The proxy server was not correctly returning Bad Request (400) status codes.
sethterashima
force-pushed
the
tesla-control-windows
branch
from
bf00c19 to
0fd9dbe
Compare
aaronpkahn
approved these changes
Mar 11, 2024
agbpatro
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds window controls to http proxy and CLI.
Fixes bug where errors were not being propagated by the http proxy.
Fixes #210
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: