-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cycle diagram #1 #2369
base: master
Are you sure you want to change the base?
cycle diagram #1 #2369
Conversation
@alixander PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No the path should be perfectly circular like in my PR (#2362).

But the paths should start/stop at the shape bounds

Hey @alixander PTAL |
@alixander Friendly ping |
Please maintain a high standard for your submissions. I appreciate your attempts but will be blocking future submissions if the standard is not raised. |
I am so sorry. |
Nice that looks close.
I think the arrowhead just points in the direction of the last 2 points. So it's likely the last 2 points are really close to each other and not going in the direction of the arc |
Hey @alixander Please do have a look. I think the purpose have been achieved. Sorry for pining too early. If i have to improve any thing please do let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a closer look at the code later but the output looks right and is promising. 👍
Signed-off-by: Mayank Mohapatra <[email protected]>
Signed-off-by: Mayank Mohapatra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I add more cases, it starts to fail strangely:

The solution does not seem robust. Please update the test to be and make sure it's generalizable to other cases.
1: "" {
shape: cycle
a -> b -> c -> d
}
2: "" {
shape: cycle
a -> b -> c
}
3: "" {
shape: cycle
a -> b
}
4: "" {
shape: cycle
a -> b -> c -> d -> e -> f
}
5: "" {
shape: cycle
a -> b -> c -> d -> e
}
Progress Till now (Purpose achieved after almost 60 tries and bunch of diff approaches)
closes #1578
/claim #1578