Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycle diagram #1 #2369

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Conversation

Mayank77maruti
Copy link

@Mayank77maruti Mayank77maruti commented Feb 21, 2025

Progress Till now (Purpose achieved after almost 60 tries and bunch of diff approaches)

sketch exp (8)

closes #1578
/claim #1578

@Mayank77maruti Mayank77maruti changed the title cycle diagram cycle diagram #1 Feb 21, 2025
@Mayank77maruti
Copy link
Author

@alixander PTAL
Thanks

@algora-pbc algora-pbc bot mentioned this pull request Feb 21, 2025
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the path should be perfectly circular like in my PR (#2362).

Screen Shot 2025-02-21 at 8 47 08 AM

But the paths should start/stop at the shape bounds

Image

@Mayank77maruti
Copy link
Author

sketch exp (2)

@Mayank77maruti
Copy link
Author

Hey @alixander PTAL
Thanks

@Mayank77maruti
Copy link
Author

@alixander Friendly ping
Thank You

@alixander
Copy link
Collaborator

@Mayank77maruti

  1. Do not ping more than once in 72 hours. Doing it one hour apart is just impatient.
  2. Does the test result look adequate to you? The lines are clearly disconnected from the shapes.

Please maintain a high standard for your submissions. I appreciate your attempts but will be blocking future submissions if the standard is not raised.

@Mayank77maruti
Copy link
Author

I am so sorry.
I will make sure I will not ping and will make sure to maintain high standards.
Again , I am sorry.

@Mayank77maruti
Copy link
Author

Todays Progress :-
sketch exp (6)
The arrow head orientation is getting a little tricky trying to figure out how to do it.
Thank YOU

@alixander
Copy link
Collaborator

alixander commented Feb 23, 2025

Nice that looks close.

The arrow head orientation is getting a little tricky trying to figure out how to do it.

I think the arrowhead just points in the direction of the last 2 points. So it's likely the last 2 points are really close to each other and not going in the direction of the arc

@Mayank77maruti
Copy link
Author

Hey @alixander Please do have a look. I think the purpose have been achieved.
sketch exp (8)

Sorry for pining too early. If i have to improve any thing please do let me know.
Thank YOU.

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a closer look at the code later but the output looks right and is promising. 👍

Signed-off-by: Mayank Mohapatra <[email protected]>
Signed-off-by: Mayank Mohapatra <[email protected]>
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add more cases, it starts to fail strangely:

Screenshot 2025-02-23 at 1 55 28 PM

The solution does not seem robust. Please update the test to be and make sure it's generalizable to other cases.

1: "" {
  shape: cycle
  a -> b -> c -> d
}
2: "" {
  shape: cycle
  a -> b -> c
}
3: "" {
  shape: cycle
  a -> b
}
4: "" {
  shape: cycle
  a -> b -> c -> d -> e -> f
}
5: "" {
  shape: cycle
  a -> b -> c -> d -> e
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shape: cycle
2 participants