Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shape: cycle #1578

Open
alixander opened this issue Sep 7, 2023 · 9 comments · May be fixed by #2369
Open

shape: cycle #1578

alixander opened this issue Sep 7, 2023 · 9 comments · May be fixed by #2369
Assignees

Comments

@alixander
Copy link
Collaborator

see: #1330

Still undecided about name. I may want to reserve "radial" for 1 thing in center and N connected.

@cyborg-ts cyborg-ts added this to D2 Sep 7, 2023
@alixander
Copy link
Collaborator Author

Screen Shot 2023-09-12 at 11 08 41 AM

@bo-ku-ra
Copy link
Contributor

how about "shape: cycle"

@alixander alixander changed the title shape: loop shape: cycle Sep 14, 2023
@alixander
Copy link
Collaborator Author

i like that better, ty for the suggestion! @bo-ku-ra

@alixander
Copy link
Collaborator Author

alixander commented Feb 19, 2025

some sample code, mostly done with ai: #2362

can't get the tracing to borders working with these arcs

@alixander
Copy link
Collaborator Author

alixander commented Feb 19, 2025

/bounty $50

task is to get the curves in that PR to start/stop at borders of objects while looking smooth

Run TA=1 ./ci/test.sh ./e2etests -run TestE2E/txtar/cycle-diagram -v to generate the test file

the path should be perfectly circular like in my PR (#2362).

Screen Shot 2025-02-21 at 8 47 08 AM

But the paths should start/stop at the shape bounds

Image

Copy link

algora-pbc bot commented Feb 19, 2025

💎 $50 bounty • Terrastruct

Steps to solve:

  1. Start working: Comment /attempt #1578 with your implementation plan
  2. Submit work: Create a pull request including /claim #1578 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to terrastruct/d2!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @shailedrathakur300 Feb 19, 2025, 4:35:18 PM WIP
🔴 @loop-index Feb 19, 2025, 4:36:00 PM WIP
🟢 @Mayank77maruti #2369

@loop-index
Copy link

loop-index commented Feb 19, 2025

/attempt #1578

@Mayank77maruti Mayank77maruti linked a pull request Feb 21, 2025 that will close this issue
@Mayank77maruti
Copy link

/attempt #1578

Copy link

algora-pbc bot commented Feb 21, 2025

💡 @Mayank77maruti submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants