fix: standardize ibm catalog json and da inputs #275
Conversation
|
/run pipeline |
|
/run pipeline |
|
The upgrade test(s) should fail due to the input name changes. They are not skipped yet, to validate the failure is as expected. |
|
/run pipeline |
|
The only error is a new property not existing on the main branch (as expected) for the upgrade tests |
|
/run pipeline |
|
/run pipeline |
| @@ -73,7 +73,7 @@ | |||
| } | |||
| ], | |||
| "architecture": { | |||
| "descriptions": "Creates or uses an existing IBM Container Registry namespace, configures pull traffic and storage quotas, and supports upgrading the registry plan to Standard.", | |||
| "description": "Creates or uses an existing IBM Container Registry namespace, configures pull traffic and storage quotas, and supports upgrading the registry plan to Standard.", | |||
There was a problem hiding this comment.
We can remove the whole description from here. We got confirmation on Friday that this is a bug in their docs, and is not a valid field at all.
There was a problem hiding this comment.
After discussion, this matches current schema. This should be fixed after the schema changes.
modules/quotas/variables.tf
Outdated
| type = string | ||
| description = "The endpoint of the IBM Container Registry, eg. https://us.icr.io or https://de.icr.io, to change quotas" |
There was a problem hiding this comment.
The default does not have https:// is it optional? I think the default should match the description format to avoid confusion.
There was a problem hiding this comment.
Addressed in latest commit
|
/run pipeline |
| "key": "tags" | ||
| "key": "tags", | ||
| "custom_config": { | ||
| "grouping": "deployment", |
There was a problem hiding this comment.
one small tweak I think we should make across the board is add the type to the custom config. So before grouping, add "type": "array" @ocofaigh FYI
This way at least to me its clear what is happening. its an array type with string elements.
The groupings are unrelated to anything we do but are required.
There was a problem hiding this comment.
addressed in latest commit
|
/run pipeline |
Description
Standardize solution inputs, including variables and catalog (tile) information.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
DA inputs change from resource_group_name and use_existing_resource_group to a single input, existing_resource_group_name. Input validations are made stricter.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers