-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat!: add support for pod_cidr_overprovision_config #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -562,6 +562,12 @@ resource "google_container_cluster" "primary" { | |
| } | ||
| } | ||
| stack_type = var.stack_type | ||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = var.pod_cidr_overprovision_config | ||
| content { | ||
| disabled = var.pod_cidr_overprovision_config.disabled | ||
| } | ||
| } | ||
| } | ||
|
|
||
| maintenance_policy { | ||
|
|
@@ -918,6 +924,7 @@ locals { | |
| "flex_start", | ||
| "local_ssd_ephemeral_storage_count", | ||
| "ephemeral_storage_local_ssd_data_cache_count", | ||
| "pod_cidr_overprovision_config", | ||
| ] | ||
| } | ||
|
|
||
|
|
@@ -1047,6 +1054,13 @@ resource "google_container_node_pool" "windows_pools" { | |
| enable_private_nodes = lookup(network_config.value, "enable_private_nodes", null) | ||
| {% endif %} | ||
|
|
||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = lookup(network_config.value, "pod_cidr_overprovision_config", "") != "" ? [1] : [] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The condition |
||
| content { | ||
| disabled = lookup(network_config.value, "pod_cidr_overprovision_config", null) | ||
| } | ||
| } | ||
|
|
||
| dynamic "network_performance_config" { | ||
| for_each = lookup(network_config.value, "total_egress_bandwidth_tier", "") != "" ? [1] : [] | ||
| content { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -429,6 +429,12 @@ resource "google_container_cluster" "primary" { | |
| } | ||
| } | ||
| stack_type = var.stack_type | ||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = var.pod_cidr_overprovision_config | ||
| content { | ||
| disabled = var.pod_cidr_overprovision_config.disabled | ||
| } | ||
| } | ||
|
Comment on lines
+432
to
+437
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| } | ||
|
|
||
| maintenance_policy { | ||
|
|
@@ -747,6 +753,13 @@ resource "google_container_node_pool" "pools" { | |
| pod_range = lookup(network_config.value, "pod_range", null) | ||
| enable_private_nodes = lookup(network_config.value, "enable_private_nodes", null) | ||
|
|
||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = lookup(network_config.value, "pod_cidr_overprovision_config", "") != "" ? [1] : [] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The condition |
||
| content { | ||
| disabled = lookup(network_config.value, "pod_cidr_overprovision_config", null) | ||
| } | ||
| } | ||
|
|
||
| dynamic "network_performance_config" { | ||
| for_each = lookup(network_config.value, "total_egress_bandwidth_tier", "") != "" ? [1] : [] | ||
| content { | ||
|
|
@@ -1113,6 +1126,13 @@ resource "google_container_node_pool" "windows_pools" { | |
| pod_range = lookup(network_config.value, "pod_range", null) | ||
| enable_private_nodes = lookup(network_config.value, "enable_private_nodes", null) | ||
|
|
||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = lookup(network_config.value, "pod_cidr_overprovision_config", "") != "" ? [1] : [] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The condition |
||
| content { | ||
| disabled = lookup(network_config.value, "pod_cidr_overprovision_config", null) | ||
| } | ||
| } | ||
|
|
||
| dynamic "network_performance_config" { | ||
| for_each = lookup(network_config.value, "total_egress_bandwidth_tier", "") != "" ? [1] : [] | ||
| content { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -330,6 +330,12 @@ resource "google_container_cluster" "primary" { | |
| } | ||
| } | ||
| stack_type = var.stack_type | ||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = var.pod_cidr_overprovision_config | ||
| content { | ||
| disabled = var.pod_cidr_overprovision_config.disabled | ||
| } | ||
| } | ||
|
Comment on lines
+333
to
+338
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| } | ||
|
|
||
| maintenance_policy { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -330,6 +330,12 @@ resource "google_container_cluster" "primary" { | |
| } | ||
| } | ||
| stack_type = var.stack_type | ||
| dynamic "pod_cidr_overprovision_config" { | ||
| for_each = var.pod_cidr_overprovision_config | ||
| content { | ||
| disabled = var.pod_cidr_overprovision_config.disabled | ||
| } | ||
| } | ||
|
Comment on lines
+333
to
+338
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| } | ||
|
|
||
| maintenance_policy { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
for_eachin this dynamic block is set tovar.pod_cidr_overprovision_config, which is an object. Thefor_eachmeta-argument only accepts a map or a set of strings, so this will cause a Terraform error. Sincevar.pod_cidr_overprovision_confighas a default value, this block is always intended to be present. It should be defined as a static block instead of a dynamic one.