-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add auto_monitoring_config in GKE managed_prometheus #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ba27a17
448446b
3371847
478f8f4
2fa8538
c42abe5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -973,6 +973,23 @@ variable "monitoring_enable_managed_prometheus" { | |
| default = null | ||
| } | ||
|
|
||
| variable "monitoring_auto_monitoring_config_scope" { | ||
| default = "NONE" | ||
| description = "Whether or not to enable GKE Auto-Monitoring. Supported values include: ALL, NONE" | ||
| type = string | ||
|
|
||
| validation { | ||
| condition = contains( | ||
| [ | ||
| "ALL", | ||
| "NONE", | ||
| ], | ||
| var.monitoring_auto_monitoring_config_scope | ||
| ) | ||
| error_message = "'monitoring_auto_monitoring_config_scope' value is invalid" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
| variable "monitoring_enable_observability_metrics" { | ||
| type = bool | ||
| description = "Whether or not the advanced datapath metrics are enabled." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -973,6 +973,23 @@ variable "monitoring_enable_managed_prometheus" { | |
| default = null | ||
| } | ||
|
|
||
| variable "monitoring_auto_monitoring_config_scope" { | ||
| default = "NONE" | ||
| description = "Whether or not to enable GKE Auto-Monitoring. Supported values include: ALL, NONE" | ||
| type = string | ||
|
|
||
| validation { | ||
| condition = contains( | ||
| [ | ||
| "ALL", | ||
| "NONE", | ||
| ], | ||
| var.monitoring_auto_monitoring_config_scope | ||
| ) | ||
| error_message = "'monitoring_auto_monitoring_config_scope' value is invalid" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
| variable "monitoring_enable_observability_metrics" { | ||
| type = bool | ||
| description = "Whether or not the advanced datapath metrics are enabled." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -937,6 +937,23 @@ variable "monitoring_enable_managed_prometheus" { | |
| default = null | ||
| } | ||
|
|
||
| variable "monitoring_auto_monitoring_config_scope" { | ||
| default = "NONE" | ||
| description = "Whether or not to enable GKE Auto-Monitoring. Supported values include: ALL, NONE" | ||
| type = string | ||
|
|
||
| validation { | ||
| condition = contains( | ||
| [ | ||
| "ALL", | ||
| "NONE", | ||
| ], | ||
| var.monitoring_auto_monitoring_config_scope | ||
| ) | ||
| error_message = "'monitoring_auto_monitoring_config_scope' value is invalid" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
| variable "monitoring_enable_observability_metrics" { | ||
| type = bool | ||
| description = "Whether or not the advanced datapath metrics are enabled." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -937,6 +937,23 @@ variable "monitoring_enable_managed_prometheus" { | |
| default = null | ||
| } | ||
|
|
||
| variable "monitoring_auto_monitoring_config_scope" { | ||
| default = "NONE" | ||
| description = "Whether or not to enable GKE Auto-Monitoring. Supported values include: ALL, NONE" | ||
| type = string | ||
|
|
||
| validation { | ||
| condition = contains( | ||
| [ | ||
| "ALL", | ||
| "NONE", | ||
| ], | ||
| var.monitoring_auto_monitoring_config_scope | ||
| ) | ||
| error_message = "'monitoring_auto_monitoring_config_scope' value is invalid" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
| variable "monitoring_enable_observability_metrics" { | ||
| type = bool | ||
| description = "Whether or not the advanced datapath metrics are enabled." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -955,6 +955,23 @@ variable "monitoring_enable_managed_prometheus" { | |
| default = null | ||
| } | ||
|
|
||
| variable "monitoring_auto_monitoring_config_scope" { | ||
| default = "NONE" | ||
| description = "Whether or not to enable GKE Auto-Monitoring. Supported values include: ALL, NONE" | ||
| type = string | ||
|
|
||
| validation { | ||
| condition = contains( | ||
| [ | ||
| "ALL", | ||
| "NONE", | ||
| ], | ||
| var.monitoring_auto_monitoring_config_scope | ||
| ) | ||
| error_message = "'monitoring_auto_monitoring_config_scope' value is invalid" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
| variable "monitoring_enable_observability_metrics" { | ||
| type = bool | ||
| description = "Whether or not the advanced datapath metrics are enabled." | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation error message is a bit generic. It would be more helpful to the user if it listed the allowed values.