-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): Add example for creating a connection #753
feat(bigquery): Add example for creating a connection #753
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels insufficient even though it's the base resource to describe how to create a connection. Can you share what page this will end up on? I think based on the docs I just browsed, it feels like this could be a snippet but the file should have the full set of resources required.
From https://cloud.google.com/bigquery/docs/connections-api-intro#connection_types it seems that there will be a specific external data source and so I'd expect this to have something like that.
This corresponds to https://cloud.google.com/bigquery/docs/create-cloud-resource-connection#terraform. @pratikmore0290 I'd rename the folder to |
/gcbrun |
7d7b6e2
to
7ed16a8
Compare
/gcbrun |
Based on comments, I expect this CI validation to fail: /gcbrun |
701e4bc
to
5205a40
Compare
/gcbrun |
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/bigquery/docs/create-cloud-resource-connection#create-cloud-resource-connection
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review