Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): Add example for creating a connection #753

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

pratikmore0290
Copy link
Contributor

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@pratikmore0290 pratikmore0290 requested review from a team as code owners October 25, 2024 00:39
Copy link

snippet-bot bot commented Oct 25, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pratikmore0290
Copy link
Contributor Author

/gcbrun

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels insufficient even though it's the base resource to describe how to create a connection. Can you share what page this will end up on? I think based on the docs I just browsed, it feels like this could be a snippet but the file should have the full set of resources required.

From https://cloud.google.com/bigquery/docs/connections-api-intro#connection_types it seems that there will be a specific external data source and so I'd expect this to have something like that.

@wj-chen
Copy link

wj-chen commented Oct 25, 2024

This feels insufficient even though it's the base resource to describe how to create a connection. Can you share what page this will end up on? I think based on the docs I just browsed, it feels like this could be a snippet but the file should have the full set of resources required.

From https://cloud.google.com/bigquery/docs/connections-api-intro#connection_types it seems that there will be a specific external data source and so I'd expect this to have something like that.

This corresponds to https://cloud.google.com/bigquery/docs/create-cloud-resource-connection#terraform.

@pratikmore0290 I'd rename the folder to /bigquery_create_connection_cloud_resource to mention the connection type

@pratikmore0290
Copy link
Contributor Author

/gcbrun

@pratikmore0290
Copy link
Contributor Author

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Nov 4, 2024

Based on comments, I expect this CI validation to fail: /gcbrun

@glasnt glasnt added the waiting-response Waiting for issue author to respond. label Nov 4, 2024
@glasnt
Copy link
Contributor

glasnt commented Nov 5, 2024

/gcbrun

@glasnt glasnt merged commit 6e0a556 into terraform-google-modules:main Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-response Waiting for issue author to respond.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants