-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding examples for integrationconnectors endpointattachment and managed zone #751
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
8fde2dc
to
2c88409
Compare
Please issue /gcbrun |
/gcbrun |
1 similar comment
/gcbrun |
The first error these samples encountered (for managed zone):
Is it expected that this service account is created when the connectors.googleapis.com API is enabled? Could you instead use a custom service account? Also checking if these code samples are valid (given you're trying to setup DNS for example.com, I'm not sure if this is something that should be provisionable). If it's not, please provide a I'll add comments for code review onto the code itself. |
/gcbrun |
/gcbrun |
Adding examples for integrationconnectors endpointattachment and managed zone
Description
Fixes b/374649808
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
[YES] Yes, this sample will be (or already is) included on cloud.google.com
Location(s):https://cloud.google.com/integration-connectors/docs/sample-terraform-template
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review