feat: Support defining tags per subnet name #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh, that'll teach me to not check open PR's first... #1131 does essentially the same thing... |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Refreshed branch from master 👍 |
|
Any update on this? It would be quite useful! |
3 tasks
|
This PR has been automatically marked as stale because it has been open 30 days |
fatmcgav
force-pushed
the
feat-support-per-subnet-name-tags
branch
from
5c8c99e to
bc75244
Compare
|
Still would be good to get this merged. I've just rebased from |
This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.
Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.
```terraform
private_subnet_names = ["Private Subnet One", "Private Subnet Two"]
private_subnet_tags_per_name = {
"Private Subnet One" = {
"subnet one" = "true"
},
"Private Subnet Two" = {
"subnet two" = "true"
}
}
```
Needed to upgraded to latest `0.19.0` version locally...
fatmcgav
force-pushed
the
feat-support-per-subnet-name-tags
branch
from
bc75244 to
00252ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.
Motivation and context
Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.
Fixes #1129