Skip to content

fix: Enable transit mode encryption var as it is now available in redis #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

willejs
Copy link

@willejs willejs commented Apr 8, 2025

Description

This allows you to set transit mode encryption for instances other than memcached, but retains the existing behavior of setting it to true for memcached by default.

Motivation and Context

I want to beable to set this for redis, which i currently cannot. If you cant set this, you can't create users, so you need to be able to set this.

Breaking Changes

None, see comment and above.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@willejs willejs marked this pull request as ready for review April 8, 2025 11:57
@willejs willejs changed the title fix: enable transit mode encryption var as it is now available in redis fix: Enable transit mode encryption var as it is now available in redis Apr 8, 2025
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if support was added for this, we'll need to ensure the min supported version of the AWS provider supports this as well

@willejs
Copy link
Author

willejs commented Apr 22, 2025

Good point, I tested this locally and It looks like this was added back in https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.16.0 so it should be fine?

@willejs willejs requested a review from bryantbiggs April 22, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants