Optimization in LSTM for batch > 1 cases on HiFi. #3244
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonnet
requested changes
Oct 27, 2025
Comment on lines
+669
to
+673
| const auto& size_info = op_data.size_info; | ||
| if(size_info.batch_size > 1 && size_info.time_steps == 1) { | ||
| num_batches = size_info.batch_size; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe move this up to the definition of num_batches and do the logic there? I think all those values should be const int as well.
Comment on lines
811
to
+813
| } else { | ||
| // batch first, unable to size the input data. single batch inference | ||
| for (int b = 0; b < size_info.batch_size; b++) { | ||
| for (int t = 0; t < size_info.time_steps; t++) { | ||
| lstm_internal::LstmStep<ActivationType, WeightType, CellType, BiasType>( | ||
| step_info, op_data, kernel_content, buffers); | ||
| // prepare for the next time step | ||
| step_info.UpdateTime(); | ||
| if(size_info.batch_size > 1 && size_info.time_steps == 1) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling batching in LSTM on HiFi for cases where batch > 1 and time iteration = 1 irrespective of time_major flag to improve optimization.
bug=fixes #3243