Skip to content

remove dist-import in node & layers #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

remove dist-import in node & layers #1956

wants to merge 2 commits into from

Conversation

WenheLI
Copy link
Contributor

@WenheLI WenheLI commented Sep 2, 2019

This is about tensorflow/tfjs-node#289.
This pr removes dist-importing in tfjs-node and tfjs-layers.
The rest of the removing will be at a separate PR.


This change is Reviewable

@WenheLI
Copy link
Contributor Author

WenheLI commented Sep 2, 2019

@dsmilkov - Hey Daniel, it seems that the CI will run changes separately based on different folders they are in.
Am I right about this?
As I need to import tslint in the root folder, but the test in react-native does not have the change about tslint in the root folder.

@dsmilkov
Copy link
Contributor

dsmilkov commented Sep 6, 2019

Hi, yes, CI runs separately for each folder, however because you are touching the global tslint.json, which is shared across all projects, the CI will run the lint job across all folders. So you will need to fix the dist imports across all projects.

@WenheLI WenheLI closed this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants