Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Improve training progress bar #243

Merged
merged 6 commits into from
Apr 18, 2019
Merged

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Apr 5, 2019

  1. Throttle render rate at 50 ms; previously it was 16 ms.
  2. When metrics string is too long, cut it off to avoid new lines being
    created constantly
  3. Adaptively set the threshold for metrics string length based on
    console width
  4. Avoid very long number strings (e.g., 0.0000000007) when
    a metric has a very small positive value.

Fixes tensorflow/tfjs#1468


This change is Reviewable

1. Throttle render rate at 50 ms; previously it was 16 ms.
2. When metrics string is too long, cut it off to avoid constant
   line wrappig.
3. Adaptively set the threshold for metrics string length based on
   console width

Fixes tensorflow/tfjs#1468
@caisq caisq requested a review from nkreeger April 5, 2019 19:09
@caisq
Copy link
Contributor Author

caisq commented Apr 11, 2019

Gentle ping.

Copy link
Contributor

@nkreeger nkreeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkreeger)

@caisq caisq merged commit 21666b0 into tensorflow:master Apr 18, 2019
@caisq caisq deleted the node-progress-fix branch April 18, 2019 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nodejs progress bar will wrap endlessly if outputs > placeholder length
2 participants