Formatting only: run code through scripts/format_all.sh #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhucka
added
the
area/health
mhucka
changed the title
Collaborator
MichaelBroughton
left a comment
MichaelBroughton
left a comment
There was a problem hiding this comment.
Thanks for the formatting updates! Happy to merge those, but I don't think we should take on the extra maintenance burden of the the blame-ignore-revs here since it looks like it adds complexity for how we need to merge PRs that isn't worth putting on people anytime we have a formatting change that they want to add to this list. This is a small repo and we need to keep these sorts of things as small as possible.
| @@ -0,0 +1,12 @@ | |||
| # Usage: run the following command to configure git to use this file: | |||
Collaborator
There was a problem hiding this comment.
This looks like a neat feature, but it is more maintenance to keep up to date. I'd be inclined to just not bother here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial deviations from
clang-formatin a small number of files seem to have crept in over time. This meant that running the format check scripts inscripts/could report changes that are not a contributors' actual changes. To prevent possible confusion to developers and maintainers, this commit:./scripts/format_all.sh.git-blame-ignore-revsfilegit config blame.ignoreRevsFileon the file.git-blame-ignore-revsineffective.