chore: Keep v1 and v0 in envd #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good signal to step forward to a more promising future of API. But could we have a guide for developers a whole view of v2? |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
gaocegege
changed the title
gaocegege
changed the title
kemingy
reviewed
Dec 7, 2022
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
|
Comments are addressed, please take a look. |
|
CI report failed because it should |
kemingy
approved these changes
Dec 7, 2022
|
Will fix the CI test coverage report in another PR. |
|
tql |
AlexXi19
pushed a commit
to AlexXi19/envd
that referenced
this pull request
Dec 12, 2022
* feat: Add v1 and v0 Signed-off-by: Ce Gao <[email protected]> * fix: Fix lint Signed-off-by: Ce Gao <[email protected]> * fix: Fix Signed-off-by: Ce Gao <[email protected]> * fix: Mock generation Signed-off-by: Ce Gao <[email protected]> * fix: Add build Signed-off-by: Ce Gao <[email protected]> * fix: Fix test cases Signed-off-by: Ce Gao <[email protected]> * fix: Update Signed-off-by: Ce Gao <[email protected]> * fix: Fix Signed-off-by: Ce Gao <[email protected]> * fix: Update Signed-off-by: Ce Gao <[email protected]> * fix: Fix test case Signed-off-by: Ce Gao <[email protected]> Signed-off-by: Ce Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ce Gao [email protected]