chore: generate discovery artifacts in CI instead of checking them in#433
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
👋 Thanks for submitting a service to the MPP directory! Before we review, please make sure you've completed these steps: Required
Recommended
Review criteriaWe prioritize services that are high quality and novel. We may not approve services that duplicate existing functionality or aren't yet production-ready. 📖 Contributing guide · 🔍 MPPScan · 📄 Protocol docs |
brendanjryan
force-pushed
the
ci/generate-artifacts-in-ci
branch
from
1ed7898 to
4c99442
Compare
brendanjryan
force-pushed
the
ci/generate-artifacts-in-ci
branch
from
4c99442 to
0bb2704
Compare
brendanjryan
force-pushed
the
ci/generate-artifacts-in-ci
branch
from
0bb2704 to
d98c8b1
Compare
- Remove discovery.json, discovery.example.json, llms.txt, and icons from git; add to .gitignore - Add generation to dev script so pnpm dev works without manual steps - Add generation to CI test/typecheck jobs; drop generated-freshness job - Remove manual generation instructions from service PR guide
brendanjryan
force-pushed
the
ci/generate-artifacts-in-ci
branch
from
d98c8b1 to
3848e8f
Compare
This was referenced Mar 23, 2026
brendanjryan
added a commit
that referenced
this pull request
Mar 25, 2026
These files were added to .gitignore in #433 but never removed from git tracking. Running git rm --cached so the gitignore actually takes effect and PRs stop getting conflicts on generated files.
itsaark
added a commit
to itsaark/mpp
that referenced
this pull request
Mar 27, 2026
discovery.json is now generated in CI (see tempoxyz#433, tempoxyz#459) and no longer tracked. The GovLaws service entry in schemas/services.ts merged cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop checking in generated files (
discovery.json,discovery.example.json,llms.txt, icons). They're now generated on-the-fly:pnpm dev— runsgenerate-discovery.ts+gen-icons.cjsbefore starting Vitepnpm build— already ran generation as its first step (no change)testandtypecheckjobs now run generation before their checksWhat changed
.gitignoreand removed them from gitdevscript to generate before starting Vitegenerated-freshnessCI job (no longer needed)node scripts/generate-discovery.tsto CItestandtypecheckjobsNo more "run
generate-discovery.tsand commit" dance.