chore: open-source readiness cleanup#358
Conversation
- Remove checkpoint-fix.yml (internal CI workflow with internal URLs, secrets, emails) - Move PostHog key from hardcoded to VITE_POSTHOG_KEY env var - Remove TODO comment in llms-token-count.yml revealing internal plans - .vercel/ already gitignored and untracked (confirmed) - AGENTS.md reviewed: no sensitive content, appropriate as contributing guide - tempoxyz/tempo is public, references are fine - vocs pinning: v2 has no stable npm release yet (only pkg.pr.new previews), keeping current
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a0b56938d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!import.meta.env.PROD) return; | ||
| if (!POSTHOG_SNIPPET) return; |
There was a problem hiding this comment.
Preserve PostHog init until deploy envs are updated
In any production build where VITE_POSTHOG_KEY has not been added yet, usePostHog() now returns at _layout.tsx and never loads PostHog. That means every captureEvent(...) call in src/lib/posthog.ts is silently dropped after the retry loop, so this change disables all analytics on existing deployments until the new env var is provisioned out of band. Because the repo change only updates .env.example, I'd keep the current key as a fallback or fail the build when the variable is missing.
Useful? React with 👍 / 👎.
Open-source readiness fixes
Prepares the repo for public release by removing internal artifacts and hardcoded keys.
Changes
Remove
checkpoint-fix.yml— Internal CI workflow containing internal Checkpoint app URLs,checkpoint@tempo.xyzemail, and references to internal secrets (CHECKPOINT_SECRET,GH_PAT,AMP_API_KEY)Move PostHog key to env var — The PostHog project key (
phc_...) was hardcoded in_layout.tsx. Now reads fromVITE_POSTHOG_KEYenv var, with a null guard so analytics is disabled when unset. Added to.env.example.Remove TODO comment —
llms-token-count.ymlhad a TODO about replacing build steps "once the site is public" — removes the comment that reveals internal launch plans.Not changed (verified OK)
.vercel/— Already in.gitignoreand not trackedAGENTS.md— Reviewed: contains documentation conventions and contributing guidance only, no sensitive contenttempoxyz/temporeferences — Repo is public, links are finevocspinning — Vocs v2 has no stable npm release (onlypkg.pr.newpreviews); no better option available yetsiwx-audit.txt— Was untracked (never committed), deleted from working treeDeploy note
Add
VITE_POSTHOG_KEY=phc_aNlTw2xAUQKd9zTovXeYheEUpQpEhplehCK5r1e31HRto Vercel environment variables to maintain analytics.