feat: change demo placeholder URL from stripe.com to stratechery.com#330
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brendanjryan
force-pushed
the
feat/stratechery-demo-link
branch
from
0519354 to
a77257b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0519354528
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!hash.startsWith("#")) return; | ||
| initialHashHandled.current = true; | ||
| const serviceId = hash.slice("#service-".length); | ||
| const serviceId = hash.slice(1); |
There was a problem hiding this comment.
This hash parser now only accepts the new #<serviceId> format, so links generated before this change (for example /services#service-openai, which this component previously wrote) no longer expand the target row because service-openai is treated as a literal ID and fails the services.some(...) check. This breaks existing bookmarked/shared deep links for users who got URLs from the prior behavior.
Useful? React with 👍 / 👎.
brendanjryan
force-pushed
the
feat/stratechery-demo-link
branch
from
a77257b to
e27909c
Compare
brendanjryan
force-pushed
the
feat/stratechery-demo-link
branch
from
e27909c to
17c0658
Compare
Update the article and lookup demo steps to default to stratechery.com. Add canned summary and company entry for Stratechery.
brendanjryan
force-pushed
the
feat/stratechery-demo-link
branch
from
17c0658 to
eb40b2d
Compare
1 participant
Updates the terminal demo's default URL from
stripe.comtostratechery.com/2025/the-agentic-web-and-original-sin/(Ben Thompson's The Agentic Web and Original Sin).Changes:
terminal-steps.ts— placeholder in article and lookup steps now uses the full Stratechery article URLTerminal.tsx— addedstratechery.comto client-side COMPANIES maparticle.ts— added canned summary; curated summaries now take priority over live Parallel extraction for consistent demo behaviorlookup.ts— added canned company entryTypes check and all 2675 unit tests pass.