Repository navigation
Conversation
|
@smoltafet is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Fixes #4042. In the Pending Activities view of a workflow:
0s, meaning unlimited) could only be seen in the JSON view.This PR updates the pending activity card to:
activityOptionswhen populated, falling back to the ActivityTaskScheduled event attributes.The display logic lives in two new utilities (
pending-activity-timeoutsandpending-activity-elapsed) so it is unit-testable without rendering the card, following the pattern ofactivity-options-diff(including its duration parsing: the HTTP API sends protojson seconds strings, the proto types describe{seconds, nanos}, and a zero duration is treated as unset).Screenshots (if applicable) 📸
No screenshot: I don't have a running Temporal server with a multi-attempt pending activity handy. The new rows appear in the card's left detail column directly under the Attempt row, in the same label/value style as the existing rows.
Design Considerations 🎨
activities.heartbeat-timeoutlabel.Testing 🧪
How was this tested 👻
New unit tests cover:
getPendingActivityTimeouts: all four timeouts formatted in order; zero/missing durations left blank for the "Not set / Unlimited" label; proto object durations and seconds-string durations both parsed; the populated-options guard.getPendingActivityElapsed: started attempt split from total; waiting attempt measured from the last attempt completion; first-attempt fallback to the scheduled time; fallback to the pending activity's scheduledTime when the scheduled event is unavailable; empty result with no anchors.Suites run locally (Node 24, vitest): the two new test files plus
pending-activitiesandactivity-options-diff(37 tests), then the fullsrc/lib/utilities,src/lib/i18n,grouped-event-bufferandsrc/lib/modelssuites: 139 files, 2010 tests passed, 1 skipped, 0 failed.svelte-check: 0 errors (63 pre-existing warnings in unrelated files). ESLint and Prettier clean on all touched files.Steps for others to test: 🚶♂️🚶♀️
Checklists
Draft Checklist
N/A
Merge Checklist
N/A
Issue(s) closed
#4042
Docs
Any docs updates needed?
No doc updates needed; this only adds display rows to an existing view.