Delete Namespace: allow to delete protected namespace in the cluster which is not in the list of namespace cluster #7851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which is not in the list of namespace cluster
laniehei
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Delete Namespace: allow to delete protected namespace in the cluster which is not in the list of namespace cluster.
Why?
If namespace was successfully removed from the cluster, it is ok to delete it event if it is protected.
How did you test it?
Potential risks
This is nondeterministic change for
DeleteNamespaceworkflow (local activity used to be executed always but now only when current cluster is in the list of clusters) but this is very short lived workflow. Chances to catch NDE is very minimal.