Dynamic config generic parse hooks #7840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
approved these changes
Jun 3, 2025
common/dynamicconfig/collection.go
Outdated
|
|
||
| out := mth.Func.Call([]reflect.Value{reflect.Zero(t), reflect.ValueOf(data)}) | ||
| if !out[1].IsNil() { | ||
| return nil, out[1].Interface().(error) // nolint:revive // type checked above |
There was a problem hiding this comment.
Where does this error go? Is it logged or returned anywhere? I see in the test that Get doesn't return it.
There was a problem hiding this comment.
It gets sometimes-logged here:
temporal/common/dynamicconfig/collection.go
Line 268 in a5ed8ee
There was a problem hiding this comment.
on second thought I'll check the conversion just in case
dnr
force-pushed
the
dc24enum
branch
2 times, most recently
from
1477cd2 to
685a70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add interfaces that can be used for types to implement custom dynamic config parsing.
Why?
It's nice to be able to parse strings into enum values.
How did you test it?