Swallowed cancellation #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
May 29, 2025
cretz
reviewed
May 30, 2025
cretz
approved these changes
May 30, 2025
There was a problem hiding this comment.
Looks great, thanks! Can see if @dandavison wants to review too
Thanks, I defer to @cretz's review here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adding an sdk flag in preparation for respecting workflow cancellation when an activity is completing.
Why?
It's possible for a cancellation to be silently swallowed without visibility to the user
Checklist
Prepares for [Bug] Workflow cancellation can be swallowed #620, which cannot be closed for another release for backwards compatibility.
How was this tested:
New replay tests
Any docs updates needed?
No