Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Nexus error message #1863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better Nexus error message #1863

wants to merge 1 commit into from
+2 −2

Conversation

rodrigozhou
Copy link
Contributor

What was changed

Using %q to quote vars in error message.
Replace reflect.Type.Name() with reflect.Type.String(): it returns the type name with prefixed with package name (Name() can be empty).

Why?

It's more clear when the variable is an empty string.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@rodrigozhou rodrigozhou requested a review from a team as a code owner March 11, 2025 21:57
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/better-error-message branch from 90b1589 to f30ce48 Compare March 12, 2025 15:59
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/better-error-message branch from f30ce48 to 4478958 Compare March 13, 2025 07:36
@rodrigozhou rodrigozhou enabled auto-merge (squash) March 13, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@pdoerner pdoerner pdoerner approved these changes

@bergundy bergundy Awaiting requested review from bergundy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigozhou @Quinn-With-Two-Ns @pdoerner