Replace github.com/pborman/uuid with github.com/google/uuid
#1854
+94
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Yeah latest github.com/pborman/uuid just delegates to github.com/google/uuid anyways. I am fine with this change, @Quinn-With-Two-Ns?
|
Yeah this should be fine since |
Quinn-With-Two-Ns
approved these changes
Feb 27, 2025
Quinn-With-Two-Ns
force-pushed
the
refactor/uuid
branch
from
6795bcb to
c014370
Compare
The `github.com/pborman/uuid` package is no longer actively maintained (last release in 2019), so we should switch to the newer `github.com/google/uuid`. Additionally, `github.com/pborman/uuid` already relies on `github.com/google/uuid` internally, so it makes sense to use `github.com/google/uuid` directly. Signed-off-by: Eng Zer Jun <[email protected]>
Quinn-With-Two-Ns
force-pushed
the
refactor/uuid
branch
from
c014370 to
c3abcc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Replace all usages of
github.com/pborman/uuidtogithub.com/google/uuid.Why?
Currently we have two UUID packages as dependencies:
sdk-go/go.mod
Line 13 in 9ce2508
sdk-go/go.mod
Line 28 in 9ce2508
The
github.com/pborman/uuidpackage is no longer actively maintained (last release in 2019), so we should switch to the newergithub.com/google/uuid.Additionally,
github.com/pborman/uuidalready relies ongithub.com/google/uuidinternally, so it makes sense to usegithub.com/google/uuiddirectly.Checklist