Repository navigation
Read task queue from TEMPORAL_TASK_QUEUE (all 6 SDK quickstarts) - #88
Merged
Merged
Conversation
The go and python standalone-activities quickstarts hardcode the task
queue ("quickstart-standalone-activities"). Read TEMPORAL_TASK_QUEUE
when set, falling back to that same literal, so a copy-paste user is
unaffected but a test harness can isolate each run on its own unique
queue. The activity ids are already unique per run (greet-<nanos>), so
no id change is needed. Worker and client share the value, so they stay
in sync automatically.
Scope: go + python quickstarts. The ts/java/dotnet/ruby quickstarts
follow the same pattern and are a follow-up.
…starts
Extends the go+python change to the remaining four SDK quickstarts: each
reads TEMPORAL_TASK_QUEUE when set, defaulting to the shared literal
("quickstart-standalone-activities"), so a copy-paste user is unaffected
but a test harness can isolate each run on its own unique queue. Activity
ids are already unique per run (greet-<nanos>), so no id change is needed.
andrewzamojc
changed the title
This was referenced Sep 29, 2026
andrewzamojc
marked this pull request as ready for review
September 29, 2026 21:09
WadeWaldron
requested changes
Oct 1, 2026
There was a problem hiding this comment.
The comments here seem unnecessary. They read as a history of the change, rather than the current state. They also repeat what the code is saying.
I'd revert the comments to the original version, unless there's something concrete that we can add in the comment.
The code itself seems fine.
This applies to all of the files.
Per review: the added comment lines described the change and repeated the code. Keep the TEMPORAL_TASK_QUEUE code, restore the original comments.
WadeWaldron
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Lets a test harness name the task queue in the standalone-activities quickstarts, so the steps and examples can be exercised automatically against a live server.
Summary
Parameterize the task queue via
TEMPORAL_TASK_QUEUEacross all six SDK quickstarts (go, typescript, python, java, dotnet, ruby), each defaulting to today's literal (quickstart-standalone-activities). A copy-paste user is unaffected; a test harness can set a unique queue per run to isolate concurrent runs in one namespace (no cross-execution contamination) and use the task queue as a precise discovery key.Activity ids are already unique per run (
greet-<nanos>), so no id change is needed. Worker and client share the value, so they stay in sync.Per-SDK change (one constant each)
go
greet/activity.go· pythonshared.py· typescriptsrc/shared.ts· javaGreeting.java· dotnetShared.cs(const→static readonly) · rubyshared.rbTest plan
TEMPORAL_TASK_QUEUEis set (go, python, ts, ruby checked locally).temporal activity list --query 'TaskQueue=…'.